9227 ipd: this statement may fall through

Review Request #928 — Created March 4, 2018 and submitted

tsoome
illumos-gate
9227
257b5c5...
general
../../common/inet/ipd/ipd.c:1093:9: error: this statement may fall through [-Werror=implicit-fallthrough=]
   error = DDI_SUCCESS;
../../common/inet/ipd/ipd.c:1094:2: note: here
  default:
  ^~~~~~~
cc1: all warnings being treated as errors


seeemef@mac.com
  1. Ship It!
  2. 
      
gwr
  1. There have been a few of these "statement may fall through" warning fixes that found real problems (like this one). When that happens, technically we should have tests to affirm corrected behavior, right? I know that imposes a greater burden when fixing some of these, so perhaps we (developers, advocates?) should talk about how we want to deal wit that.

  2. usr/src/uts/common/inet/ipd/ipd.c (Diff revision 1)
     
     

    I guess DDI_INFO_DEV2INSTANCE never worked?

    1. Obviously not. Also I'm not sure, but some of those interfaces are obsolete and not in use anyhow (should re-read wdd:).

  3. 
      
citrus
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...