9242 st: this statement may fall through

Review Request #935 - Created March 6, 2018 and submitted

Information
Toomas Soome
illumos-gate
9242
56ec1cb...
Reviewers
general
../../common/io/scsi/targets/st.c:18498:16: error: this statement may fall through [-Werror=implicit-fallthrough=]
     reset_type = RESET_ALL;
../../common/io/scsi/targets/st.c:18499:4: note: here
    default:
    ^~~~~~~
../../common/io/scsi/targets/st.c: In function 'st_decode_sense':
../../common/io/scsi/targets/st.c:11207:8: error: this statement may fall through [-Werror=implicit-fallthrough=]
     if (ri->pkt_retry_cnt++ < st_retry_count) {
        ^
../../common/io/scsi/targets/st.c:11212:4: note: here
    default: /* FALLTHRU */
    ^~~~~~~
../../common/io/scsi/targets/st.c: In function 'st_set_state':
../../common/io/scsi/targets/st.c:12040:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
    if (new_lastop != ST_OP_NIL) {
       ^
../../common/io/scsi/targets/st.c:12043:3: note: here
   default:
   ^~~~~~~
../../common/io/scsi/targets/st.c: In function 'st_modesense':
../../common/io/scsi/targets/st.c:8164:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
   if (un->un_dp->options & ST_MODE_SEL_COMP) {
      ^
../../common/io/scsi/targets/st.c:8185:2: note: here
  default: /* FALLTHROUGH */
  ^~~~~~~
cc1: all warnings being treated as errors

  
C Fraire
Andy Fiddaman
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...