9265 e1000g: this statement may fall through

Review Request #941 - Created March 11, 2018 and submitted

Information
Toomas Soome
illumos-gate
9265
121a126...
Reviewers
general
../../common/io/e1000api/e1000_82575.c:1681:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
   pcs_autoneg = FALSE;
../../common/io/e1000api/e1000_82575.c:1683:2: note: here
  default:
  ^~~~~~~
../../common/io/e1000api/e1000_82575.c: In function 'e1000_get_media_type_82575':
../../common/io/e1000api/e1000_82575.c:1803:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
   if (e1000_sgmii_uses_mdio_82575(hw)) {
      ^
../../common/io/e1000api/e1000_82575.c:1809:2: note: here
  case E1000_CTRL_EXT_LINK_MODE_PCIE_SERDES:
  ^~~~

../../common/io/e1000api/e1000_phy.c: In function 'e1000_copper_link_setup_m88_gen2':
../../common/io/e1000api/e1000_phy.c:1296:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
   if (phy->id != M88E1112_E_PHY_ID) {
      ^
../../common/io/e1000api/e1000_phy.c:1300:2: note: here
  case 0:
  ^~~~

../../common/io/e1000api/e1000_vf.c:489:10: error: this statement may fall through [-Werror=implicit-fallthrough=]
   msgbuf |= E1000_VF_SET_PROMISC_MULTICAST;
../../common/io/e1000api/e1000_vf.c:490:2: note: here
  case e1000_promisc_unicast:
  ^~~~

../../common/io/e1000api/e1000_mbx.c: In function 'e1000_init_mbx_params_pf':
../../common/io/e1000api/e1000_mbx.c:780:19: error: this statement may fall through [-Werror=implicit-fallthrough=]
   mbx->stats.rsts = 0;
   ~~~~~~~~~~~~~~~~^~~
../../common/io/e1000api/e1000_mbx.c:781:2: note: here
  default:
  ^~~~~~~

cc1: all warnings being treated as errors

  
Yuri Pankov
Sebastian Wiedenroth
Yuri Pankov
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...