9313 cmd/fs.d: this statement may fall through

Review Request #976 — Created March 19, 2018 and submitted

tsoome
illumos-gate
9313
f3e65bd...
general
hsfs/labelit: this statement may fall through

labelit.c: In function 'updatelabel':
labelit.c:53:39: error: this statement may fall through [-Werror=implicit-fallthrough=]
 #define PUTSECTOR(buf, secno, nosec) (putdisk(buf, (secno)*ISO_SECTOR_SIZE, \
                                      ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  (nosec)*ISO_SECTOR_SIZE))
  ~~~~~~~~~~~~~~~~~~~~~~~~~
labelit.c:332:3: note: in expansion of macro 'PUTSECTOR'
   PUTSECTOR(unix_buf, unix_pvd_sec_no, 1);
   ^~~~~~~~~
labelit.c:337:2: note: here
  case 1:
  ^~~~
cc1: all warnings being treated as errors

udfs/fsck: this statement may fall through

pass1.c:170:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
    ckinode(fp);
    ^~~~~~~~~~~
pass1.c:171:3: note: here
   default:
   ^~~~~~~
cc1: all warnings being treated as errors

ufs/mkfs: this statement may fall through

mkfs.c:925:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   usage();
   ^~~~~~~
mkfs.c:927:2: note: here
  case 15:
  ^~~~
cc1: all warnings being treated as errors

ufs/fsdb: this statement may fall through

fsdb.c:414:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
    if (isnumber(optarg)) {
       ^
fsdb.c:426:3: note: here
   case 'o':
   ^~~~
cc1: all warnings being treated as errors

newfs: this statement may fall through

newfs.c:865:5: error: this statement may fall through [-Werror=implicit-fallthrough=]
     fatal(gettext(
     ^~~~~~~~~~~~~~
         "%s: I/O error accessing VTOC"), name);
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
newfs.c:868:4: note: here
    case VT_EINVAL:
    ^~~~
newfs.c:869:5: error: this statement may fall through [-Werror=implicit-fallthrough=]
     fatal(gettext(
     ^~~~~~~~~~~~~~
         "%s: Invalid field in VTOC"), name);
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
newfs.c:872:4: note: here
    default:
    ^~~~~~~
cc1: all warnings being treated as errors

autofs: this statement may fall through

autod_nfs.c:4293:15: error: this statement may fall through [-Werror=implicit-fallthrough=]
   ping_server = 1;
   ~~~~~~~~~~~~^~~
autod_nfs.c:4294:2: note: here
  case SERVER_ADDR:
  ^~~~
cc1: all warnings being treated as errors

smbutil: this statement may fall through

smbutil.c:156:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
    help();
    ^~~~~~
smbutil.c:158:3: note: here
   case 'v':
   ^~~~
cc1: all warnings being treated as errors

ff: this statement may fall through

ff.c:355:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   exit(1);
   ^~~~~~~
ff.c:356:2: note: here
  case -1:
  ^~~~
ff.c:358:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   exit(2);
   ^~~~~~~
ff.c:359:2: note: here
  default:
  ^~~~~~~
cc1: all warnings being treated as errors


citrus
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
seeemef@mac.com
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...