3328 smbutil view does't work with Win2008 and later

Reviews
Diff

- Download Diff

Information
Submitter:	Gordon Ross
Repository:	illumos-gate
Branch:
Bugs:	3328
Depends On:
Reviewers
Groups:	general
People:

Description

3328 smbutil view does't work with Win2008 and later

Note: Requires 1575, also up for review in: https://www.illumos.org/rb/r/982/

Testing Done

Run "smbutil view //server" against a modern Windows, i.e.

$ smbutil view //w530gwr
Password:
Share        Type       Comment
-------------------------------
ADMIN$       disk       Remote Admin
C$           disk       Default share
g            disk       
IPC$         IPC        Remote IPC
Junk         disk       
print$       disk       Printer Drivers
public       disk       
Users        disk

Issues

0
4
1
All Issues: 5

Description	From	Last Updated
cstyle police:) it is good to have red markers...	Toomas Soome	March 19, 2018, 8:49 p.m.
cstyle police again.	Toomas Soome	March 19, 2018, 8:49 p.m.
also cstyle here..	Toomas Soome	March 19, 2018, 8:49 p.m.
and finally, here.	Toomas Soome	March 19, 2018, 8:49 p.m.
Is there a reason this is an 'INOUT', when the interface description above describes it as only an 'IN'? The ...	Matt Barden	March 22, 2018, 11:57 p.m.

Description:

		3328 smbutil view does't work with Win2008 and later
	+
	+	Note: Requires 1575 (also out for review)

Description:

		3328 smbutil view does't work with Win2008 and later

~		Note: Requires 1575 (also out for review)
	~	Note: Requires 1575, also up for review in: https://www.illumos.org/rb/r/982/

usr/src/cmd/fs.d/smbclnt/smbutil/smbutil.c (Diff revision 1)

Show all issues

cstyle police:) it is good to have red markers...

usr/src/cmd/fs.d/smbclnt/smbutil/smbutil.c (Diff revision 1)

Show all issues

cstyle police again.

usr/src/cmd/fs.d/smbclnt/smbutil/srvsvc1.ndl (Diff revision 1)

Show all issues

also cstyle here..

usr/src/cmd/fs.d/smbclnt/smbutil/view.c (Diff revision 1)

Show all issues

and finally, here.

Change Summary:

cstyle

Diff:

Revision 2 (+882 -470)

Show changes

	usr/src/cmd/fs.d/smbclnt/smbutil/Makefile
	usr/src/cmd/fs.d/smbclnt/smbutil/common.h
	usr/src/cmd/fs.d/smbclnt/smbutil/info.c
	usr/src/cmd/fs.d/smbclnt/smbutil/shares_rap.c
	usr/src/cmd/fs.d/smbclnt/smbutil/shares_rpc.c
	usr/src/cmd/fs.d/smbclnt/smbutil/smbutil.c
	usr/src/cmd/fs.d/smbclnt/smbutil/srvsvc1.ndl
	usr/src/cmd/fs.d/smbclnt/smbutil/srvsvc1_clnt.h
	9 more

usr/src/cmd/fs.d/smbclnt/smbutil/srvsvc1.ndl (Diff revision 2)

Show all issues

Is there a reason this is an 'INOUT', when the interface description above describes it as only an 'IN'?

The union is also and 'INOUT', when the interface description describes it as an 'OUT'

Gordon Ross March 22, 2018, 11:53 p.m.

I don't know. I simply copied the few things this needs from the server srvsvc.ndl
It looks the same over there.
http://src.illumos.org/source/xref/illumos-gate/usr/src/uts/common/smbsrv/ndl/srvsvc.ndl#1349
I'm hesitant to change these since this is all mature code with some test mileage.

Matt Barden March 22, 2018, 11:57 p.m.
```
Weird. I guess that's OK then.
```

Ship it!

Ship It!

Ship it!

Ship It!

You have a pending review.

Review Board 2.5.16

Screenshots

Files

Issues

Description:

Description:

Change Summary:

Diff:

Status: Closed (submitted)